Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder all serde_bincode_compat module definitions #11416

Closed
shekhirin opened this issue Oct 2, 2024 · 1 comment · Fixed by #11435
Closed

Reorder all serde_bincode_compat module definitions #11416

shekhirin opened this issue Oct 2, 2024 · 1 comment · Fixed by #11435
Labels
C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

We have a bunch of serde_bincode_compat modules across the crates, and most of them are defined after the tests module. It's weird and we should reorder it, so that mod tests goes last.

For example:

#[test]
fn create_txs_disallowed_for_eip4844() {
let data =
[3, 208, 128, 128, 123, 128, 120, 128, 129, 129, 128, 192, 129, 129, 192, 128, 128, 9];
let res = TransactionSigned::decode_2718(&mut &data[..]);
assert!(res.is_err());
}
}
/// Bincode-compatible transaction type serde implementations.
#[cfg(feature = "serde-bincode-compat")]
pub mod serde_bincode_compat {

Additional context

No response

@shekhirin shekhirin added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt A clean up/refactor of existing code labels Oct 2, 2024
@shekhirin shekhirin removed the C-enhancement New feature or request label Oct 2, 2024
@varun-doshi
Copy link
Contributor

I can take this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants