Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce Block trait abstraction #11240

Closed
Tracked by #11239
mattsse opened this issue Sep 26, 2024 · 0 comments · Fixed by #11399
Closed
Tracked by #11239

introduce Block trait abstraction #11240

mattsse opened this issue Sep 26, 2024 · 0 comments · Fixed by #11399
Assignees
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 26, 2024

we need to gradually introduce traits for the block type

this should leverage alloy traits where it makes sense (e.g. Transaction trait or Encodeable)

First step is introducing the associated types

pub trait NodePrimitives {}

in a follow we can further enforce and restrict this to reth_primitives types at first, like we currently do with the unified ChainSpec type before we move to traits entirely.

ref #9029 for an initial draft, we need a Block trait that contains a body type, the body then contains the transactions. This way we can design the body as we like (e.g. withdrawals, requests, etc..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants