Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special module handling for eth_callBundle #10483

Closed
mattsse opened this issue Aug 23, 2024 · 1 comment · Fixed by #10486
Closed

Remove special module handling for eth_callBundle #10483

mattsse opened this issue Aug 23, 2024 · 1 comment · Fixed by #10486
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 23, 2024

Describe the feature

when we introduced this we weren't sure if we should consider this part of the regular eth namespace and opted for an additional config:

/// For single non-standard `eth_` namespace call `eth_callBundle`
///
/// This is separate from [`RethRpcModule::Eth`] because it is a non standardized call that
/// should be opt-in.
EthCallBundle,

but now we can simply consider this part of the regular eth_ namespace and enable it by default because useful

TODO

  • remove EthCallBundle module and install ethcallbundle if Eth is enabled

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 23, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Aug 23, 2024
@rutefig
Copy link

rutefig commented Aug 23, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Working currently with another project in Rust in the Ethereum Ecossystem, I want to contribute more for meaningful projects on the Ecosystem.

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants