Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract Chainspec #10272

Closed
klkvr opened this issue Aug 12, 2024 · 2 comments
Closed

Abstract Chainspec #10272

klkvr opened this issue Aug 12, 2024 · 2 comments
Labels
C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity

Comments

@klkvr
Copy link
Collaborator

klkvr commented Aug 12, 2024

Describe the feature

Current Chainspec is pretty much Ethereum-specifc

reth/crates/chainspec/src/spec.rs

Line 282 in af85c13

pub struct ChainSpec {

We should turn it into a trait instead, making all functions into trait methods and getting rid of Arc<Chainspec> usage across codebase

Additional context

No response
@klkvr klkvr added the C-enhancement New feature or request label Aug 12, 2024
@klkvr klkvr mentioned this issue Aug 14, 2024
Merged
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain and removed C-enhancement New feature or request labels Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emhane @klkvr