Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only mark propagated txs as seen #10213

Closed
mattsse opened this issue Aug 8, 2024 · 1 comment · Fixed by #10234
Closed

Only mark propagated txs as seen #10213

mattsse opened this issue Aug 8, 2024 · 1 comment · Fixed by #10234
Assignees
Labels
C-bug An unexpected or incorrect behavior C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 8, 2024

Describe the feature

currently we're marking txs as seen

for tx in &to_propagate {
if peer.seen_transactions.insert(tx.hash()) {

before we're truncating the hashes or full transactions:

new_pooled_hashes.truncate(
SOFT_LIMIT_COUNT_HASHES_IN_NEW_POOLED_TRANSACTIONS_BROADCAST_MESSAGE,
);

let new_full_transactions = full_transactions.build();

TODO

  • only check if !.contains and only insert actually propagated txs into seen_transactions

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 8, 2024
@mattsse mattsse added C-bug An unexpected or incorrect behavior D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Aug 8, 2024
@SkandaBhat
Copy link
Contributor

SkandaBhat commented Aug 8, 2024

Hey @mattsse could I pick this up? Can you assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants