From f3fd7e73ccb6a91fe1a92bda9b96a53ca0193607 Mon Sep 17 00:00:00 2001
From: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Date: Wed, 3 Jul 2024 21:48:41 +0200
Subject: [PATCH] fix: always evaluate build_profile_name at compile time
 (#9278)

---
 .../node/core/src/metrics/version_metrics.rs  |  4 +--
 crates/node/core/src/version.rs               | 30 +++++++++----------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/crates/node/core/src/metrics/version_metrics.rs b/crates/node/core/src/metrics/version_metrics.rs
index cea907fc3ca0..03769d990f35 100644
--- a/crates/node/core/src/metrics/version_metrics.rs
+++ b/crates/node/core/src/metrics/version_metrics.rs
@@ -1,6 +1,6 @@
 //! This exposes reth's version information over prometheus.
 
-use crate::version::{build_profile_name, VERGEN_GIT_SHA};
+use crate::version::{BUILD_PROFILE_NAME, VERGEN_GIT_SHA};
 use metrics::gauge;
 
 /// Contains version information for the application.
@@ -28,7 +28,7 @@ impl Default for VersionInfo {
             cargo_features: env!("VERGEN_CARGO_FEATURES"),
             git_sha: VERGEN_GIT_SHA,
             target_triple: env!("VERGEN_CARGO_TARGET_TRIPLE"),
-            build_profile: build_profile_name(),
+            build_profile: BUILD_PROFILE_NAME,
         }
     }
 }
diff --git a/crates/node/core/src/version.rs b/crates/node/core/src/version.rs
index 5151b861d586..adc922787189 100644
--- a/crates/node/core/src/version.rs
+++ b/crates/node/core/src/version.rs
@@ -70,9 +70,23 @@ pub const LONG_VERSION: &str = const_format::concatcp!(
     env!("VERGEN_CARGO_FEATURES"),
     "\n",
     "Build Profile: ",
-    build_profile_name()
+    BUILD_PROFILE_NAME
 );
 
+pub(crate) const BUILD_PROFILE_NAME: &str = {
+    // Derived from https://stackoverflow.com/questions/73595435/how-to-get-profile-from-cargo-toml-in-build-rs-or-at-runtime
+    // We split on the path separator of the *host* machine, which may be different from
+    // `std::path::MAIN_SEPARATOR_STR`.
+    const OUT_DIR: &str = env!("OUT_DIR");
+    let unix_parts = const_format::str_split!(OUT_DIR, '/');
+    if unix_parts.len() >= 4 {
+        unix_parts[unix_parts.len() - 4]
+    } else {
+        let win_parts = const_format::str_split!(OUT_DIR, '\\');
+        win_parts[win_parts.len() - 4]
+    }
+};
+
 /// The version information for reth formatted for P2P (devp2p).
 ///
 /// - The latest version from Cargo.toml
@@ -116,20 +130,6 @@ pub fn default_client_version() -> ClientVersion {
     }
 }
 
-pub(crate) const fn build_profile_name() -> &'static str {
-    // Derived from https://stackoverflow.com/questions/73595435/how-to-get-profile-from-cargo-toml-in-build-rs-or-at-runtime
-    // We split on the path separator of the *host* machine, which may be different from
-    // `std::path::MAIN_SEPARATOR_STR`.
-    const OUT_DIR: &str = env!("OUT_DIR");
-    let unix_parts = const_format::str_split!(OUT_DIR, '/');
-    if unix_parts.len() >= 4 {
-        unix_parts[unix_parts.len() - 4]
-    } else {
-        let win_parts = const_format::str_split!(OUT_DIR, '\\');
-        win_parts[win_parts.len() - 4]
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;