Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you use the experimental association-tracking feature? #1070

Closed
jaredbeck opened this issue Mar 24, 2018 · 8 comments
Closed

Do you use the experimental association-tracking feature? #1070

jaredbeck opened this issue Mar 24, 2018 · 8 comments

Comments

@jaredbeck
Copy link
Member

Association tracking is an endangered feature. For the past three or four years it has been an experimental feature, not recommended for production. It has a long list of known issues and has no regular volunteers caring for it.

If you use this experimental feature, react with 👍

If you want to volunteer to care for it, please comment below.

If we can't make a serious dent in the list of known issues over the next few years, then I'm inclined to delete it, though that would make me sad because I've put dozens of hours into it, and I know others have too.

@jaredbeck
Copy link
Member Author

If you are using this endangered feature, please subscribe to this issue. If no one volunteers to take care of this feature, then its deprecation and eventual deletion will be announced here.

@westonganger
Copy link
Contributor

westonganger commented May 14, 2018

I think it is a bad idea to remove this feature even without maintainers. There is currently no other gem that provides this functionality. Removing it would be a shame to the Rails community and will also limit people who wish to upgrade to newer versions of paper_trail. However if it could be extracted into a separate gem ie. paper_trail_association_tracking that would be a good idea.

@jaredbeck
Copy link
Member Author

However if it could be extracted into a separate gem ie. paper_trail_association_tracking that would be a good idea.

It should be possible. You've made some contributions recently, Weston, would you like to maintain it? I can help you extract the gem if you want to pair on it.

@westonganger
Copy link
Contributor

Yeah I think I could probably swing that. To be honest though, I don't really know anything about the code behind the feature however I'm sure during extraction into a gem I will start to get a feel for a majority of it. So after its been extracted, I probably wouldn't be making many major contributions myself to the code other than maintainer stuff. As issues and PR's roll in I'll start to have more to say in how it goes down though.

Please provide some insight on where to start looking and tinkering.

@jaredbeck
Copy link
Member Author

Please provide some insight on where to start looking and tinkering.

Great! Can you pair with me on it over screen-share? Please email me jared at jaredbeck dot com. Thanks.

@westonganger
Copy link
Contributor

westonganger commented May 20, 2018

I spent a bit of time tonight getting this repo started: https://github.com/westonganger/paper_trail-association_tracking

  • I started by copying this repo and removed most of the paper_trail only stuff.
  • See the TODO section in the readme for the current task list

@jaredbeck
Copy link
Member Author

jaredbeck commented May 21, 2018

.. if it could be extracted into a separate gem ..

I spent a bit of time tonight getting this repo started: https://github.com/westonganger/paper_trail_associations_tracking I started by copying this repo and removed most of the paper_trail only stuff.

That sounds like a good approach. I am picturing the following milestones:

  1. paper_trail gemspec has a runtime dependency on the new gem for a year or so, and keeps all existing tests.
  2. paper_trail gemspec has a development dependency on the new gem for a year or so, and keeps all existing tests.
  3. Eventually, paper_trail does not depend on or test the new gem

Regarding the gem name, paper_trail-associations_tracking is the recommended punctuation, per the rubygems.org Name your gem guide. (See the "Use dashes for extensions" section)

@jaredbeck
Copy link
Member Author

jaredbeck commented Jun 4, 2018

Closed via #1103. Will release as 9.2.0. No breaking changes are anticipated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants