Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#466 adding application/jwk-set+json for JWTS calls #467

Merged
merged 2 commits into from
Feb 3, 2022
Merged

#466 adding application/jwk-set+json for JWTS calls #467

merged 2 commits into from
Feb 3, 2022

Conversation

frederik
Copy link
Contributor

@frederik frederik commented Feb 3, 2022

Adding application/jwk-set+json as an accepted header, since some OIDC providers are stricter and will return a 406 error code otherwise.

Adding application/jwk-set+json as an accepted header, since some OIDC providers are stricter and will return a 406 error code otherwise.
panva
panva previously requested changes Feb 3, 2022
Copy link
Owner

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update test/issuer/issuer_instance.test.js line 38 with the updated header value.

@frederik
Copy link
Contributor Author

frederik commented Feb 3, 2022

@panva thanks for the patience. Can you please check the latest commit? The tests are passing now - I had to change a few more matchHeaders

@panva panva dismissed their stale review February 3, 2022 13:31

Resolved.

@panva panva merged commit f94d42b into panva:main Feb 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants