Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: issuer discovery #637

Merged
merged 4 commits into from
Dec 6, 2023
Merged

refactor: issuer discovery #637

merged 4 commits into from
Dec 6, 2023

Conversation

big-kahuna-burger
Copy link
Contributor

Just splits uri detection code from a call to discovery endpoint and avoids duplication

@big-kahuna-burger big-kahuna-burger changed the title Refactor issuer discovery refactor: issuer discovery Nov 26, 2023
panva
panva requested changes Nov 27, 2023
View reviewed changes
Copy link
Owner

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the getUri function to the root of the file, so that it's not part of the discover function

panva
panva requested changes Nov 27, 2023
View reviewed changes
lib/issuer.js Outdated Show resolved Hide resolved
lib/issuer.js Outdated Show resolved Hide resolved
@big-kahuna-burger
Copy link
Contributor Author

@panva ptal

@panva panva merged commit c228877 into panva:main Dec 6, 2023
30 checks passed
@big-kahuna-burger big-kahuna-burger deleted the refactors-discovery branch December 6, 2023 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@panva panva panva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-kahuna-burger @panva