Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import v8 from node internal #555

Closed
wants to merge 1 commit into from
Closed

Import v8 from node internal #555

wants to merge 1 commit into from

Conversation

LoiLock
Copy link

@LoiLock LoiLock commented Jan 10, 2023

Fixes:
image

@panva
Copy link
Owner

panva commented Jan 10, 2023 •
edited
Loading

Hi @LoiLock

There is no practical difference between v8 and node:v8 in the Node.js runtime.

> require('v8') === require('node:v8')
true

The former is however not supported in all of the major versions this library currently targets.

I'm going to go ahead and close this. I don't think there's anything to fix. If anything it might be a tooling issue related to your setup.

@panva panva closed this Jan 10, 2023
panva added a commit that referenced this pull request Feb 2, 2023
@panva
refactor: remove use of Node.js v8 builtin
f1881bc 
Refs: #442
Refs: #475
Refs: #555
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoiLock @panva