Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently writing some tests for handling errors from
openid-client
and while attempting to instantiate one of the errors, I noticed that the constructor types don't match the implementation.Since the types don't explicitly declare a
constructor
, they inherit they inherit it fromError
, which doesn't match their overloaded constructors.So, I tried adding what I think are roughly the correct constructor types for the
OPError
andRPError
classes. I saw that there is aopenid-client-tests.ts
file, so let me know if there's anything additional I should add there as well. Or, feel free to push any additional updates that you see fit to this branch.Thanks!