Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript - reference to dom and AbortSignal #433

Closed
Luzgan opened this issue Dec 1, 2021 · 4 comments
Closed

Typescript - reference to dom and AbortSignal #433

Luzgan opened this issue Dec 1, 2021 · 4 comments
Labels

Comments

@Luzgan
Copy link

Luzgan commented Dec 1, 2021

Describe the bug
Typescript having problems with AbortSignal types, which I believe is a type from dom types. From what I see it was added in 2c1d2ab and removed in d69af6f#diff-093ad82a25aee498b11febf1cdcb6546e4d223ffcb49ed69cc275ac27ce0ccceL2
but reference to AbortSignal type stayed in there.

Environment:

  • openid-client version: [v5.0.2]
  • node version: [v12.19.0]
@Luzgan Luzgan added the triage label Dec 1, 2021
@panva
Copy link
Owner

panva commented Dec 1, 2021

AbortSignal is added as a global in Node.js 16, bumping your @types/node to 16.x will help out. I don't think I can make it so that you can stay on older versions.

@panva panva closed this as completed Dec 1, 2021
@panva panva added wontfix and removed triage labels Dec 1, 2021
@Luzgan
Copy link
Author

Luzgan commented Dec 1, 2021

Hm. Bumping types to 16, while using 12 seems wrong. I guess you should update readme, with a mention that node 16 is supported, nothing below.

@panva
Copy link
Owner

panva commented Dec 1, 2021

The supported runtimes are correct as-is. @types/node is not a runtime.

@Luzgan
Copy link
Author

Luzgan commented Dec 1, 2021

Fair enough, but maybe mention typescript problem at least :)

panva added a commit that referenced this issue Dec 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants