Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the issuer URL after discover #269

Closed
Lakshman1996 opened this issue Jun 15, 2020 · 5 comments
Closed

Modify the issuer URL after discover #269

Lakshman1996 opened this issue Jun 15, 2020 · 5 comments
Labels

Comments

@Lakshman1996
Copy link

Hi

I am discovering the issuer using Microsoft common URL to perform multi tenant auth.
i tried modifying the issuer URL in metadata as mentioned in this issue
The value in the metadata object remains same even after assigning a new value.
Is there anything that i am missing?

Thanks

@Lakshman1996 Lakshman1996 changed the title Modify the issuer url Modify the issuer URL after discover Jun 15, 2020
@panva
Copy link
Owner

panva commented Jun 15, 2020

Why are you trying to do that? Ever since 2.5.0 that shouldn't be needed anymore.

@Lakshman1996
Copy link
Author

I get this error unexpected iss value, expected https://sts.windows.net/{tenantid}/, got: https://sts.windows.net/8d88c9c2-2058-486d-9cd4-2fc9010326bc/ when is use https://login.microsoftonline.com/common for discover.

I have to use common endpoint for Multi tenant auth to work in AAD

@panva
Copy link
Owner

panva commented Jun 15, 2020

Can't you use https://login.microsoftonline.com/common/v2.0 instead? That one (v2.0) is handled and is known to be at a better level when it comes to OIDC conformance.

@panva panva closed this as completed in 2344e00 Jun 15, 2020
@panva
Copy link
Owner

panva commented Jun 15, 2020

v3.15.3 released that handles v1 common the same as v2 common.

Please consider supporting the library if it provides value to you or your company and this and the previous support was of help to you. Supporting the library means, amongst other things, that such support will be available in the future.

@Lakshman1996
Copy link
Author

Thanks for the quick reply.
Using v2.0 worked.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants