Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore post_logout_redirect_uris when logout is disabled #1221

Merged
merged 3 commits into from
May 6, 2023

Conversation

manvydasu
Copy link
Contributor

@manvydasu manvydasu commented May 6, 2023

Hello, I think there is a slight problem wtih rpInitiatedLogout configuration.

inside the client_schema.js there is this check at line 79

  if (features.rpInitiatedLogout.enabled) {
    RECOGNIZED_METADATA.push('post_logout_redirect_uris');
  }

However, it looks like it does nothing, because post_logout_redirect_uris is already included in the default RECOGNIZED_METADATA array. In order for flag features.rpInitiatedLogout.enabled to properly work, default recognized metadata properties should be changed.

I can't run tests locally due to structuredClone error, so haven't verified yet if tests don't break.

@panva panva changed the title remove 'post_logout_redirect_uris' from default metadata (RECOGNIZED_METADATA) fix: ignore post_logout_redirect_uris when logout is disabled May 6, 2023
@panva panva merged commit d7dd6cf into panva:main May 6, 2023
@panva
Copy link
Owner

panva commented May 6, 2023

Nice catch, thank you @manvydasu

@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants