Pin isort version in CI #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
isort had a regression in 4.3.11 that it no longer respects
skip_globas we intended. See PyCQA/isort#885.This motivated the problem, although there is reason to pin isort regardless of this regression. Linters and autoformatters often change their behavior with new releases. When this happens, we don't want someone's PR to fail due to an unrelated upstream change in that tool's behavior.
Solution
Pin isort to 4.3.10, the most recent release that does not have the
skip_globissue. Once this issue gets resolved, the version can be upgraded.Also fix bad imports that weren't caught with our original isort runs.
Finally, convert CLI flags to use long names.