-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor interpreter constraints even when PEX_PYTHON and PEX_PYTHON_PATH not set #668
Honor interpreter constraints even when PEX_PYTHON and PEX_PYTHON_PATH not set #668
Conversation
@blorente for point #2 you want this: For point #1 you should just be able to run pex with an |
47ea81a
to
d820a94
Compare
Depends on #673 |
78e5ab7
to
8bdd0c3
Compare
For some reason I can repro failing test (and others) locally in |
@jsirois, any idea why I can repro the failing tests in |
8bdd0c3
to
d76ead9
Compare
Replace subprocess with run_simple_pex
e1d90fb
to
5297a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Borja for working through this!
@jsirois or @CMLivingston a review of this would be quite helpful. While I'm more familiar with Pex than a few months ago, I'm still not aware of all the expectations and its history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - no issues that I can see.
In my experience, this happens because certain env conditions align locally that are not covered in CI, and the developer did not verify his/her changes by running tox locally before pushing the branch. |
Solves issue #656, where if no
PEX_PYTHON_PATH
and noPEX_PYHON
are configured, we still honour--interpreter-constraint
flag when bootstrapping a PEX.There is an integration test that worked only when applied the last commit, but there is a lot of nuance to running it that I'd like a hand with. In particular, I'd like to know if there's a way of:
"please override PEX_PYTHON_PATH with
None
". I think the first one should be easy to implement with a command-line flag defined in the same place as--rcfile
.--interpreter-constraint
).