Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden abi selection for non-specified abi types. #503

Merged
merged 2 commits into from
May 27, 2018

Conversation

kwlzn
Copy link
Contributor

@kwlzn kwlzn commented May 26, 2018

Fixes #492

@kwlzn kwlzn force-pushed the kwlzn/492 branch 2 times, most recently from 004ff64 to db450e8 Compare May 26, 2018 07:58
@kwlzn
Copy link
Contributor Author

kwlzn commented May 26, 2018

noting local success on the OSX specific integration test:

[omerta pex (kwlzn/492)]$ tox -e py27-requests -- -k test_cross_platform_abi_targeting_behavior
GLOB sdist-make: /Users/kwilson/dev/pex/setup.py
py27-requests inst-nodeps: /Users/kwilson/dev/pex/.tox/dist/pex-1.4.2.zip
py27-requests installed: certifi==2018.4.16,chardet==3.0.4,cookies==2.2.1,funcsigs==1.0.2,idna==2.6,mock==2.0.0,packaging==16.8,pbr==4.0.3,pex==1.4.2,py==1.5.3,pyparsing==2.2.0,pytest==2.9.1,requests==2.18.4,responses==0.9.0,six==1.11.0,twitter.common.contextutil==0.3.9,twitter.common.dirutil==0.3.9,twitter.common.lang==0.3.9,twitter.common.testing==0.3.9,urllib3==1.22
py27-requests runtests: PYTHONHASHSEED='1821441303'
py27-requests runtests: commands[0] | py.test -k not tests/test_integration.py -k test_cross_platform_abi_targeting_behavior
========================================================= test session starts ==========================================================
platform darwin -- Python 2.7.13, pytest-2.9.1, py-1.5.3, pluggy-0.3.1
rootdir: /Users/kwilson/dev/pex, inifile: 
collected 231 items 

tests/test_integration.py ..

================================ 229 tests deselected by '-ktest_cross_platform_abi_targeting_behavior' ================================
=============================================== 2 passed, 229 deselected in 0.95 seconds ===============================================
py27-requests runtests: commands[1] | pex --cache-dir /Users/kwilson/dev/pex/.tox/py27-requests/tmp/buildcache wheel requests . -e pex.bin.pex:main --version
pex 1.4.2
_______________________________________________________________ summary ________________________________________________________________
  py27-requests: commands succeeded
  congratulations :)

and TODO'd this with #479

@kwlzn kwlzn requested review from stuhood, jsirois and CMLivingston May 26, 2018 08:00
@kwlzn kwlzn mentioned this pull request May 26, 2018
pex/testing.py Outdated
@@ -28,6 +28,7 @@
IS_NOT_LINUX = "platform.system() != 'Linux'"
NOT_CPYTHON27_OR_OSX = "%s or %s" % (NOT_CPYTHON27, IS_NOT_LINUX)
NOT_CPYTHON27_OR_LINUX = "%s or %s" % (NOT_CPYTHON27, IS_LINUX)
NOT_CPYTHON27_OR_LINUX = "%s or %s" % (NOT_CPYTHON27, IS_LINUX)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicates line above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - fixed!

@kwlzn kwlzn merged commit 266a401 into pex-tool:master May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants