Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage subprocess32 when available. #411

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Sep 1, 2017

This allows for an upgrade in subprocess robustness when available that
Pants will leverage for one. Also formalize the pex optional
dependencies with extras_require, mainly for documentation purposes.

This allows for an upgrade in subprocess robustness when available that
Pants will leverage for one. Also formalize the pex optional
dependencies with `extras_require`, mainly for documentation purposes.
@jsirois
Copy link
Member Author

jsirois commented Sep 1, 2017

I'm not sure I understand the full negative implications - if any - of the extras_require portion of this change. If there are any I'm happy to retract that bit.

@jsirois jsirois requested a review from kwlzn September 1, 2017 18:46
@jsirois jsirois mentioned this pull request Sep 1, 2017
Copy link
Contributor

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsirois jsirois merged commit c07c70f into pex-tool:master Sep 1, 2017
@jsirois jsirois deleted the jsirois/subprocess32 branch September 1, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants