Add dummy flush method for clean interpreter exit with python3.6 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR @sveitser |
Closed
facebook-github-bot
pushed a commit
to facebook/buck
that referenced
this pull request
Sep 13, 2017
Summary: This is basically just an import of pex-tool/pex#343 Context - python3.6 started returning an exit code of 120 when the interpreter doesn't shut down correctly. The root cause of the failure is inside the pex code, but Buck interprets that exit code as a failure. Test Plan: `buck test` on an empty python test using python3.6 - confirm it doesn't fail. Reviewed By: ttsugriy fbshipit-source-id: 3a46b4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #342 for me.