Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEXBuilder.clone. #234

Closed
wants to merge 1 commit into from
Closed

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Apr 14, 2016

Previously neither shebang nor copy were cloned leading to inability to
set these attributes differently from their defaults using bdist_pex
which leverages clone.

Previously neither shebang nor copy were cloned leading to inability to
set these attributes differently from their defaults using `bdist_pex`
which leverages `clone`.
@jsirois
Copy link
Member Author

jsirois commented Apr 14, 2016

@salimfadhley - if you can review this PR I'd appreciate it.

@jsirois
Copy link
Member Author

jsirois commented Apr 14, 2016

This addresses #233

@salimfadhley
Copy link

I can have a go at testing this on Monday if you like. :-)

@jsirois
Copy link
Member Author

jsirois commented Apr 16, 2016

That would be great. I tested it for your use case on the command line as well. A code review would be welcome too.

@jsirois
Copy link
Member Author

jsirois commented Apr 19, 2016

@salimfadhley I'll submit this tomorrow if I don't here back from you.

@salimfadhley
Copy link

Hey - thanks for doing this. It's hard for me to test source at work. It
would be best for you to merge it in and then i can pull the packages and
re-test everything.

On Tue, 19 Apr 2016 at 21:52 John Sirois [email protected] wrote:

@salimfadhley https://github.com/salimfadhley I'll submit this tomorrow
if I don't here back from you.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#234 (comment)

@jsirois
Copy link
Member Author

jsirois commented Apr 19, 2016

Sounds good @salimfadhley, patched in @ 2fc3f73

@jsirois jsirois closed this Apr 19, 2016
@jsirois jsirois deleted the jsirois/issues/233 branch April 19, 2016 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants