Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pantsd] Investigate which of the calls to time.sleep() we can remove from test_pantsd_integration.py #7331

Closed
blorente opened this issue Mar 7, 2019 · 1 comment

Comments

@blorente
Copy link
Contributor

blorente commented Mar 7, 2019

It seems like many of the calls to time.sleep() are just waiting for the daemon to start up, which may be passed as a timeout to assert_started(), and that function will poll for the pid until it appears.

We may also need to add more sophisticated polling for things other than the pid appearing (such as "python has started running")

@stuhood
Copy link
Member

stuhood commented May 7, 2020

Cleaned up a few of these recently in #9660.

@stuhood stuhood closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants