You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To improve the onboarding experience, we should consider having the tailor rules for inference languages actually attempt to run inference on the files for which it is generating targets, and skip generating (possibly with a warning) if those files fail to parse.
This would be particularly helpful for files which (based on their extension) should be valid code, but which are instead templates or resources to be used by codegen or tests (another heuristic for this might be to use filenames: like src/resources on the JVM), etc.
The text was updated successfully, but these errors were encountered:
one thing which would almost work would be to have tailor execute all of its changes, and then execute a fallible validation step on the target afterward,
I suspect it's much easier to 100% localize the validation. Trying to generalize sounds like a leaky abstraction & over-eager generalization.
(imo, slightly higher priority because it's a bit of a broken window)
I believe that we should leave this ticket open to cover sources themselves. They are a slightly more expensive problem to solve: to actually parse source files for this validation, you'd need to run the dependency extraction processes, but likely with different cache keys than they would usually have.
stuhood
changed the title
Tailor should skip files for which inference cannot extract symbol information
Tailor should skip sources for which inference cannot extract symbol information
Jun 2, 2022
To improve the onboarding experience, we should consider having the
tailor
rules for inference languages actually attempt to run inference on the files for which it is generating targets, and skip generating (possibly with a warning) if those files fail to parse.This would be particularly helpful for files which (based on their extension) should be valid code, but which are instead templates or
resources
to be used by codegen or tests (another heuristic for this might be to use filenames: likesrc/resources
on the JVM), etc.The text was updated successfully, but these errors were encountered: