-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: incorporate compiler
and asm
tool flags into compile cache key
#14664
Comments
The go tool version not ending up in the cache key makes sense, because it is provided via a path rather than a digest. But it's not clear how other values would not end up as part of the process's digest: are they not part of the input files? |
GOOS and GOARCH, for example, would not be part of the cache key, unless they had been set explicitly in the environment. That said, some of the logic related to incorporating command-line options is unnecessary since they are part of the |
I think that that could be addressed by setting pants/src/rust/engine/process_execution/src/remote.rs Lines 941 to 951 in ed4d01e
|
#14661 did not add compiler options as part of the cache key since some amount of tracing values in
go
's logic was still necessary. This issue covers doing that work.The text was updated successfully, but these errors were encountered: