Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfiles: allow forcing a 3rd party requirement to be included in a resolve #12848

Closed
Eric-Arellano opened this issue Sep 10, 2021 · 1 comment
Assignees

Comments

@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Sep 10, 2021

Motivating case: @benjyw pointed out how pantsbuild/pants depends on pydevd-pycharm. He'd like it to be in our user_reqs.txt lockfile, even though it's not imported by default so not actually used by the resolve. This allows you to quickly add the dependency when debugging without re-generating and resolving the lockfile.

We should allow you to ensure that a certain python_requirement_library gets included in the input for a user resolve no matter if it's used. Probably this should be a field on python_requirement? Otherwise, it could be an option in [python-setup] that associates resolves w/ certain 3rdparty requirements.

@Eric-Arellano
Copy link
Contributor Author

This is solved via #13621 (comment). Regardless of if any code is using the requirement or not, if the python_requirement sets compatible_resolves, then it will be included in that lockfile. (And then we might subset that repository PEX to ignore it if the code doesn't use it, depending on --run-against-entire-lockfile)

Repository owner moved this from Todo to Done in Python multiple user lockfiles Dec 22, 2021
@Eric-Arellano Eric-Arellano self-assigned this Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant