Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix single lead dim not dropped in remove_bias #773

Merged
merged 22 commits into from
Aug 28, 2022

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Aug 26, 2022

Description

CLIMPRED_ENSEMBLE_DIMS shouldnt be dropped

Closes #771

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tests added for pytest, if necessary.

Checklist (while developing)

  • CHANGELOG is updated with reference to this PR.

@aaronspring aaronspring self-assigned this Aug 26, 2022
@github-actions
Copy link

Checkout your PR on Binder. Open the console and pip install -e . before using the notebooks to use climpred from this PR.

@aaronspring aaronspring marked this pull request as ready for review August 26, 2022 19:24
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #773 (f102941) into main (dafd1f3) will decrease coverage by 1.07%.
The diff coverage is 90.13%.

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   93.80%   92.73%   -1.08%     
==========================================
  Files          59       59              
  Lines        6235     6209      -26     
==========================================
- Hits         5849     5758      -91     
- Misses        386      451      +65     
Impacted Files Coverage Δ
climpred/horizon.py 96.55% <ø> (ø)
climpred/options.py 81.48% <ø> (ø)
climpred/tests/test_hindcast_prediction.py 100.00% <ø> (ø)
climpred/tests/test_logging.py 100.00% <ø> (ø)
climpred/bootstrap.py 80.52% <73.07%> (-10.36%) ⬇️
climpred/alignment.py 91.13% <73.68%> (-5.74%) ⬇️
climpred/checks.py 95.79% <83.33%> (+0.03%) ⬆️
climpred/tests/test_HindcastEnsemble_class.py 96.51% <85.71%> (-3.49%) ⬇️
climpred/utils.py 88.69% <86.66%> (-1.70%) ⬇️
climpred/classes.py 93.36% <87.35%> (-0.15%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aaronspring aaronspring merged commit d284289 into main Aug 28, 2022
@aaronspring aaronspring deleted the fix_single_lead_dim_not_dropped branch August 28, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HindcastEnsemble.remove_bias with only one lead element drops lead dimension
1 participant