Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve ImportError for version #729

Merged
merged 4 commits into from
Feb 17, 2022
Merged

resolve ImportError for version #729

merged 4 commits into from
Feb 17, 2022

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Feb 16, 2022

Description

resolve ImportError when installed climpred from conda. didnt break when installed via pip

    def add_attrs_to_climpred_coords(results):
        """Write attrs for coords added by climpred."""
>       from . import __version__ as version
E       ImportError: cannot import name '__version__' from 'climpred'

@aaronspring aaronspring self-assigned this Feb 16, 2022
@aaronspring aaronspring changed the title Update utils.py resolve ImportError for version Feb 16, 2022
@aaronspring aaronspring marked this pull request as ready for review February 16, 2022 10:05
@pangeo-data pangeo-data deleted a comment from github-actions bot Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #729 (ab0a759) into main (dafd1f3) will decrease coverage by 0.47%.
The diff coverage is 82.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   93.80%   93.33%   -0.48%     
==========================================
  Files          59       59              
  Lines        6235     6272      +37     
==========================================
+ Hits         5849     5854       +5     
- Misses        386      418      +32     
Impacted Files Coverage Δ
climpred/tests/test_bias_removal.py 97.66% <ø> (ø)
climpred/utils.py 89.82% <66.66%> (-0.57%) ⬇️
climpred/alignment.py 91.13% <73.68%> (-5.74%) ⬇️
climpred/classes.py 93.54% <83.33%> (+0.03%) ⬆️
climpred/checks.py 95.76% <100.00%> (ø)
climpred/metrics.py 91.73% <100.00%> (ø)
climpred/tests/test_alignment.py 100.00% <100.00%> (ø)
climpred/tests/test_relative_entropy.py 82.60% <100.00%> (-17.40%) ⬇️
climpred/tests/test_utils.py 99.28% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9828bda...ab0a759. Read the comment docs.

@aaronspring aaronspring merged commit bec54bc into main Feb 17, 2022
@aaronspring aaronspring deleted the fix_version branch February 17, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant