Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add_attrs into classes verify() #694

Merged
merged 15 commits into from
Dec 2, 2021

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Dec 1, 2021

Description

Closes #475

To-Do List

Type of change

  • Refactoring

How Has This Been Tested?

  • Tests added for pytest, if necessary.

Checklist (while developing)

  • CHANGELOG is updated with reference to this PR.

References

@aaronspring aaronspring self-assigned this Dec 1, 2021
@aaronspring aaronspring marked this pull request as ready for review December 2, 2021 02:33
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #694 (4ba7274) into main (a1b80a2) will decrease coverage by 0.01%.
The diff coverage is 98.13%.

❗ Current head 4ba7274 differs from pull request most recent head 60fa5ec. Consider uploading reports for the commit 60fa5ec to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   93.87%   93.85%   -0.02%     
==========================================
  Files          58       58              
  Lines        6250     6214      -36     
==========================================
- Hits         5867     5832      -35     
+ Misses        383      382       -1     
Impacted Files Coverage Δ
climpred/options.py 81.48% <ø> (ø)
climpred/prediction.py 93.16% <ø> (-0.23%) ⬇️
climpred/reference.py 97.14% <ø> (-0.08%) ⬇️
climpred/utils.py 91.11% <94.11%> (+1.03%) ⬆️
climpred/bootstrap.py 91.66% <100.00%> (-0.27%) ⬇️
climpred/classes.py 94.51% <100.00%> (-0.15%) ⬇️
climpred/metrics.py 91.78% <100.00%> (ø)
climpred/tests/test_HindcastEnsemble_class.py 100.00% <100.00%> (ø)
climpred/tests/test_graphics.py 100.00% <100.00%> (ø)
climpred/tests/test_utils.py 99.28% <100.00%> (+0.58%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b80a2...60fa5ec. Read the comment docs.

@aaronspring aaronspring merged commit 7440d7c into pangeo-data:main Dec 2, 2021
@aaronspring aaronspring deleted the refactor_attrs branch December 2, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_attrs: update and move into .verify()
1 participant