Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes after #675 #678

Merged
merged 10 commits into from
Sep 29, 2021
Merged

Fixes after #675 #678

merged 10 commits into from
Sep 29, 2021

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Sep 29, 2021

Description

  • finally fix plot
  • bootstrap doesnt create time dim in reference climatology
  • unfix xclim version

Closes #680)

To-Do List

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Performance (if you modified existing code run asv to detect performance changes)
  • Refactoring
  • Improved Documentation

How Has This Been Tested?

  • Tests added for pytest, if necessary.

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the sphinx documentation, if necessary.
  • Any new functions are added to the API. (See contribution guide)
  • CHANGELOG is updated with reference to this PR.

References

@aaronspring aaronspring changed the title Update graphics.py Fixes after #675 Sep 29, 2021
@aaronspring aaronspring marked this pull request as ready for review September 29, 2021 13:33
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #678 (1ca67b6) into main (e78f518) will increase coverage by 0.19%.
The diff coverage is 98.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   93.68%   93.87%   +0.19%     
==========================================
  Files          56       57       +1     
  Lines        6035     6077      +42     
==========================================
+ Hits         5654     5705      +51     
+ Misses        381      372       -9     
Impacted Files Coverage Δ
climpred/reference.py 97.22% <ø> (-0.04%) ⬇️
climpred/tests/test_HindcastEnsemble_class.py 100.00% <ø> (ø)
climpred/utils.py 90.07% <ø> (ø)
climpred/classes.py 94.66% <75.00%> (+0.17%) ⬆️
climpred/bias_removal.py 96.65% <100.00%> (+0.12%) ⬆️
climpred/bootstrap.py 91.93% <100.00%> (+0.38%) ⬆️
climpred/graphics.py 96.95% <100.00%> (+4.26%) ⬆️
climpred/prediction.py 93.38% <100.00%> (+0.28%) ⬆️
climpred/tests/test_valid_time.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78f518...1ca67b6. Read the comment docs.

@aaronspring aaronspring self-assigned this Sep 29, 2021
@aaronspring aaronspring merged commit d889106 into main Sep 29, 2021
@aaronspring aaronspring deleted the AS_fix_plot branch September 29, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrap(reference='climatology') creates time dimension
1 participant