Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For word STT, default to lang_code without locale #1917

Closed
2 tasks
wcjord opened this issue Feb 25, 2025 · 7 comments · Fixed by #1919
Closed
2 tasks

For word STT, default to lang_code without locale #1917

wcjord opened this issue Feb 25, 2025 · 7 comments · Fixed by #1919

Comments

@wcjord
Copy link

wcjord commented Feb 25, 2025

  • Try for full lang_code with locale
  • If not present, try with lang_code without locale
@wcjord
Copy link
Author

wcjord commented Feb 25, 2025

@ggurdin we should try to get this into this release. should be a simple fix.

@linhtphung
Copy link

When I try Spanish (Mexico) in Web Staging, I still don't have the sound for individual words. In IOS, there's only Spanish. When I chose it, My language is shown as ? in the top bar. @ggurdin

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 26, 2025

@linhtphung I just merged in changes that so fix the "?" issue on mobile. I'll upload a testflight build. As for web TTS, please check if again in ~15 minutes and let me know if it's still now working. We might have to get on a video call. Is it working for non-localized Spanish?

@linhtphung
Copy link

Is this how it's supposed to be for Spanish (Mexico)? Do I have to download a package to do this? If it's the case, it would be a barrier for the user and we need to prompt them when they click on a word @ggurdin

Image

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 26, 2025

@linhtphung Does TTS work for regular Spanish?

@linhtphung
Copy link

Yes, it works for regular Spanish.

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 26, 2025

@linhtphung This should be fixed in the next testflight build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants