Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-joining space does not select space #1820

Closed
Kelrap opened this issue Feb 17, 2025 · 6 comments · Fixed by #1827
Closed

Re-joining space does not select space #1820

Kelrap opened this issue Feb 17, 2025 · 6 comments · Fixed by #1827

Comments

@Kelrap
Copy link
Collaborator

Kelrap commented Feb 17, 2025

Normally, joining a space via public space view selects the space and opens its details page. However, when joining an already-joined space via public space view, selecting the Join Space button does nothing.

Screen.Recording.2025-02-17.at.1.58.10.PM.mov

Normal only-now-joining behavior:

Screen.Recording.2025-02-17.at.2.04.18.PM.mov
@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 24, 2025

This only works for spaces that do not require codes.

Screen.Recording.2025-02-24.at.1.17.42.PM.mov

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 25, 2025

@Kelrap I can't replicate this. Does this still happen consistently?

@Kelrap
Copy link
Collaborator Author

Kelrap commented Feb 26, 2025

@ggurdin just tested on android, and it still happened.

Are you retyping the space name in the search bar after changing the require-code setting? If I reselect the space without reloading the search, it doesn't act like the updated setting.

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 26, 2025

@Kelrap Should be fixed in the main branch. Should be good to re-test on web in ~15 minutes

@linhtphung
Copy link

I don't know what this is, please help me to test on the web @Kelrap

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 27, 2025

I don't know what this is, please help me to test on the web @Kelrap

Join a searchable space, if you're not already in one. Then search for that space, click on it, and click the join button in the popup. You should be taken to the space you were already in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants