-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "use system keyboard" a learning setting #1805
Comments
To Dos:
|
The immediate next step to this is going to be giving the user some instruction on installing a new keyboard and turning it on. Package for getting the user straight to settings on mobile: |
@linhtphung You can test this by changing the setting and seeing if it enables / disables autocorrect in your keyboard. I changed my l2 to English to test this and then intentionally made some typos. |
I don't think this is working for me. Has anybody seen it correct something? Note that we're not testing if IGC is working but rather the system keyboard corrections. I'm wondering if need to enableSuggestions in order to see corrections. |
I don't see this either. Is it supposed to underline the mispelled words as I type? |
@linhtphung Yes, it should. I just tested on iOS and it's working. What's your L2? If you L2 does not match the keyboard language, it will not work. I changed my L2 to English and typed the message "Heres a messaje" and it autocorrected it to "Here's a message". We could communicate more clearly that the keyboard has to match the language. |
Ok, then you can mark as tested on ios then. I don't change my keyboard on the computer so it's just English, I guess. |
@linhtphung Sorry, this isn't really applicable on web. I'll update the labels. Thank you! |
I have Spanish on my iphone keyboard, but it still doesn't correct me |
@linhtphung Does it correct you on other apps? For instance, does Spanish autocorrect work when searching in safari? |
No, so maybe it's another setting somewhere. |
That's possible. It also might not be as sensitive as English autocorrect. |
@ggurdin In your next TestFlight deployment, can you give us a build where that learning setting also turns on enableSuggestions? I'd like to see what that's like. |
Gotcha! |
I don't see a 'use system keyboard' option in learning settings. Am I supposed to be testing the 'Enable autocorrect' toggle? |
@Kelrap Yes |
The iOS/Android autocorrect is quite good, unless it's trying to correct the user's language to their base rather than their target. We can't determine what language the user's keyboard is set to so we don't want to automatically enable it. However, we could let them turn it on, accompanied by a message about needing to set up the needed keyboard in their mobile settings.
The text was updated successfully, but these errors were encountered: