Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "use system keyboard" a learning setting #1805

Closed
wcjord opened this issue Feb 14, 2025 · 17 comments · Fixed by #1867
Closed

Make "use system keyboard" a learning setting #1805

wcjord opened this issue Feb 14, 2025 · 17 comments · Fixed by #1867
Assignees

Comments

@wcjord
Copy link

wcjord commented Feb 14, 2025

The iOS/Android autocorrect is quite good, unless it's trying to correct the user's language to their base rather than their target. We can't determine what language the user's keyboard is set to so we don't want to automatically enable it. However, we could let them turn it on, accompanied by a message about needing to set up the needed keyboard in their mobile settings.

@ggurdin ggurdin added the good first issue Good for newcomers label Feb 17, 2025
@ggurdin
Copy link
Collaborator

ggurdin commented Feb 17, 2025

To Dos:

  1. Add this as a boolean setting in UserToolSettings (user_model.dart). Set the default value to false.
  2. Add a SwitchListTile in settings_learning_view.dart above the public profile toggle to set this value for the user. Base this on how other setter functions in settings_learning.dart work, like setPublicProfile
  3. Pull this value from pangeaController.userController in input_bar.dart to get the TextField's autocorrect and enableSuggestions values

@wcjord
Copy link
Author

wcjord commented Feb 18, 2025

The immediate next step to this is going to be giving the user some instruction on installing a new keyboard and turning it on.

Package for getting the user straight to settings on mobile:
https://pub.dev/packages/app_settings

@linhtphung
Copy link

I see: Enable autocorrect being added to learning setting. I don't see keyboard as a setting option. If this doesn't need to be tested, please remove the labels @ggurdin @Sofanyas

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 26, 2025

@linhtphung You can test this by changing the setting and seeing if it enables / disables autocorrect in your keyboard. I changed my l2 to English to test this and then intentionally made some typos.

@wcjord
Copy link
Author

wcjord commented Feb 26, 2025

I don't think this is working for me. Has anybody seen it correct something?

Note that we're not testing if IGC is working but rather the system keyboard corrections.

I'm wondering if need to enableSuggestions in order to see corrections.

@linhtphung
Copy link

I don't see this either. Is it supposed to underline the mispelled words as I type?

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 27, 2025

@linhtphung Yes, it should. I just tested on iOS and it's working. What's your L2? If you L2 does not match the keyboard language, it will not work. I changed my L2 to English and typed the message "Heres a messaje" and it autocorrected it to "Here's a message".

We could communicate more clearly that the keyboard has to match the language.

@linhtphung
Copy link

Ok, then you can mark as tested on ios then. I don't change my keyboard on the computer so it's just English, I guess.

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 27, 2025

@linhtphung Sorry, this isn't really applicable on web. I'll update the labels. Thank you!

@linhtphung
Copy link

I have Spanish on my iphone keyboard, but it still doesn't correct me

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 27, 2025

@linhtphung Does it correct you on other apps? For instance, does Spanish autocorrect work when searching in safari?

@linhtphung
Copy link

No, so maybe it's another setting somewhere.

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 27, 2025

That's possible. It also might not be as sensitive as English autocorrect.

@wcjord
Copy link
Author

wcjord commented Feb 27, 2025

@ggurdin In your next TestFlight deployment, can you give us a build where that learning setting also turns on enableSuggestions? I'd like to see what that's like.

@ggurdin
Copy link
Collaborator

ggurdin commented Feb 27, 2025

Gotcha!

@Kelrap
Copy link
Collaborator

Kelrap commented Mar 3, 2025

I don't see a 'use system keyboard' option in learning settings. Am I supposed to be testing the 'Enable autocorrect' toggle?

@ggurdin
Copy link
Collaborator

ggurdin commented Mar 3, 2025

@Kelrap Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants