-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating the trellis rplot module (GH3445) #9357
Deprecating the trellis rplot module (GH3445) #9357
Conversation
@jorisvandenbossche I redid all the examples using seaborn. A quick search didn't turn it up, but I'll dig for it later. |
There are ways to both suppress and check for warnings in the tests, we have a couple of examples of it in mpl's test suite. |
I'm not sure ggplot is ready for prime time. I would probably only recommend Seaborn at this point. |
@shoyer yes, I could agree, as I noticed while trying to convert some of the examples to gpplot this was not easy (some of the functionality of rplot is not yet included in ggplot). I will update the PR |
I agree too: ggplot currently doesn't handle categorical data very well if faceting is used (actually that was my motivation for working on categorical data in pandas :-) ). |
OK, I will remove ggplot for now from the explanation, and if @TomAugspurger finds his seaborn examples, we can add that. But @JanSchulz, if you want to add some ggplot examples when there is some progress, certainly do! |
e5a217f
to
82295ce
Compare
@jorisvandenbossche @TomAugspurger let's do this for 0.16.0 (pls add a refernce in #6581) as well |
I made some examples of how to do it with seaborn, for each example in de rplot docs now: http://nbviewer.ipython.org/gist/jorisvandenbossche/103876bff4a5f42c9933# @TomAugspurger Can you have a looks if this looks good? Or if there are better ways? (only for the last example (4 variables) I did not found a fully equivalent seaborn-way of doing it) @jreback For the actual PR, I assume adding seaborn as a doc dependency is not that handy, so I better include all the figures as images? |
Joris, I remember talking to Michael about that last plot and it was agreed
that seaborn didn't have a way to do that plot directly. It was also agreed
that this is a good thing, since that chart is a mess :) Thanks for redoing
this
|
I fully agree about that mess :-) The rest is looking OK? |
82295ce
to
e1efef3
Compare
|
||
ScaleRandomColour(column) | ||
g = sns.FacetGrid(tips_data, row="sex", col="smoker", hue="day") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might add hue_kws={"marker": ["^", "v", "s", "*"]}
if you like the symbols.... or not :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the different symbols then additional to the different colors? Or in place of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The symbols are matched with colors 1 to 1. See the Seaborn docs on plotting on data aware grids for details.
On Wed, Mar 4, 2015 at 11:23 AM, Joris Van den Bossche
[email protected] wrote:
- ScaleRandomColour(column)
- g = sns.FacetGrid(tips_data, row="sex", col="smoker", hue="day")
Are the different symbols then additional to the different colors? Or in place of?
Reply to this email directly or view it on GitHub:
https://github.com/pydata/pandas/pull/9357/files#r25804584
This looks great to me! |
@jorisvandenbossche I think just need a release note in the deprecations sections |
@jreback ah yes! |
e1efef3
to
fb12f01
Compare
Deprecating the trellis rplot module (GH3445)
xref #9357. Title is self- explanatory. Author: gfyoung <[email protected]> Closes #13855 from gfyoung/trellis-plot-remove and squashes the following commits: 5427086 [gfyoung] CLN: Removed trellis rplot
Closes #3445
Start for #3445. Then the current examples should get a seaborn or ggplot alternative.
Questions:
import pandas.tools.rplot as rplot
). The only thing is that the warning will be raised in the tests this way