-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: Fix duplicate files warning #55206
Conversation
Is there a way for meson to automatically pick these up instead of manually having to specify? For sure doesn't change often, but would be nice to avoid hard coding |
Sadly, I think it has to be hardcoded, since the meson devs discourage using things like wildcards that would let us include all pyi files at once. |
Will self merge then so this gets in for the release. |
One thing you could do is offload the file list itself to a separate plaintext file containing one filename per line, and use it from meson as: sources_to_install = fs_mod.read('sources.list').strip().split() It's then much easier to statically verify through any means you like that the list of files is updated. You could have a CI script verify it as a test, for example, or auto refresh the file via a git-pre-commit hook. This fulfills meson's requirement -- that any changes to the build plan are detected and force a reconfigure, so that running |
…g) (#55222) Backport PR #55206: BUILD: Fix duplicate files warning Co-authored-by: Thomas Li <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.