From 6a1e5487ce215dc615acd244785330e266b95277 Mon Sep 17 00:00:00 2001 From: Fangchen Li Date: Mon, 11 Sep 2023 13:38:46 -0700 Subject: [PATCH 1/4] Test installing dev dependencies with pip --- .github/workflows/pip-dev.yml | 33 +++++++++++++++++++++++++++++++++ environment.yml | 2 +- requirements-dev.txt | 1 - 3 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/pip-dev.yml diff --git a/.github/workflows/pip-dev.yml b/.github/workflows/pip-dev.yml new file mode 100644 index 0000000000000..0d943e34ecddf --- /dev/null +++ b/.github/workflows/pip-dev.yml @@ -0,0 +1,33 @@ +name: Development Environment with Pip + +on: + push: + branches: + - main + - 2.1.x + pull_request: + branches: + - main + - 2.1.x + paths: + - 'requirements-dev.txt' + +jobs: + build: + runs-on: ${{ matrix.os }} + strategy: + matrix: + python-version: ["3.9", "3.10", "3.11", "3.12"] + os: [ubuntu-latest, windows-latest, macos-latest] + + steps: + - uses: actions/checkout@v3 + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v4 + with: + python-version: ${{ matrix.python-version }} + cache: 'pip' + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install -r requirements.txt diff --git a/environment.yml b/environment.yml index 1a9dffb55bca7..1079aacf6ccd1 100644 --- a/environment.yml +++ b/environment.yml @@ -105,7 +105,7 @@ dependencies: - ipykernel # web - - jinja2 # in optional dependencies, but documented here as needed + # - jinja2 # already listed in optional dependencies, but documented here for reference - markdown - feedparser - pyyaml diff --git a/requirements-dev.txt b/requirements-dev.txt index be02007a36333..e78299c8db1e1 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -76,7 +76,6 @@ ipywidgets nbformat notebook>=6.0.3 ipykernel -jinja2 markdown feedparser pyyaml From f27a0926566503f6fb68417bb11094705376e848 Mon Sep 17 00:00:00 2001 From: Fangchen Li Date: Mon, 11 Sep 2023 13:40:49 -0700 Subject: [PATCH 2/4] fix typo --- .github/workflows/pip-dev.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pip-dev.yml b/.github/workflows/pip-dev.yml index 0d943e34ecddf..ff348b213311d 100644 --- a/.github/workflows/pip-dev.yml +++ b/.github/workflows/pip-dev.yml @@ -17,7 +17,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - python-version: ["3.9", "3.10", "3.11", "3.12"] + python-version: ["3.9", "3.10", "3.11", "3.12-dev"] os: [ubuntu-latest, windows-latest, macos-latest] steps: @@ -30,4 +30,4 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install -r requirements.txt + pip install -r requirements-dev.txt From 688f80297ea3e8c2ed030e5ac84920684d7bc93e Mon Sep 17 00:00:00 2001 From: Fangchen Li Date: Mon, 11 Sep 2023 13:45:14 -0700 Subject: [PATCH 3/4] remove 3.12, list deps --- .github/workflows/pip-dev.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pip-dev.yml b/.github/workflows/pip-dev.yml index ff348b213311d..5d320a84c106c 100644 --- a/.github/workflows/pip-dev.yml +++ b/.github/workflows/pip-dev.yml @@ -17,7 +17,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - python-version: ["3.9", "3.10", "3.11", "3.12-dev"] + python-version: ["3.9", "3.10", "3.11"] os: [ubuntu-latest, windows-latest, macos-latest] steps: @@ -31,3 +31,6 @@ jobs: run: | python -m pip install --upgrade pip pip install -r requirements-dev.txt + - name: List dependencies + run: | + pip list From 1bb4081b0b4928001597b4ddfcf3ba8b59e19f25 Mon Sep 17 00:00:00 2001 From: Fangchen Li Date: Wed, 13 Sep 2023 12:10:39 -0700 Subject: [PATCH 4/4] remove pip ci test --- .github/workflows/pip-dev.yml | 36 ----------------------------------- 1 file changed, 36 deletions(-) delete mode 100644 .github/workflows/pip-dev.yml diff --git a/.github/workflows/pip-dev.yml b/.github/workflows/pip-dev.yml deleted file mode 100644 index 5d320a84c106c..0000000000000 --- a/.github/workflows/pip-dev.yml +++ /dev/null @@ -1,36 +0,0 @@ -name: Development Environment with Pip - -on: - push: - branches: - - main - - 2.1.x - pull_request: - branches: - - main - - 2.1.x - paths: - - 'requirements-dev.txt' - -jobs: - build: - runs-on: ${{ matrix.os }} - strategy: - matrix: - python-version: ["3.9", "3.10", "3.11"] - os: [ubuntu-latest, windows-latest, macos-latest] - - steps: - - uses: actions/checkout@v3 - - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v4 - with: - python-version: ${{ matrix.python-version }} - cache: 'pip' - - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install -r requirements-dev.txt - - name: List dependencies - run: | - pip list