-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: deprecate sortlevel in favor of sort_index #15099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Minor comment.
Apart from that, should we add a basic sortlevel test that tests that a warning is raised and that it gives the same as sort_index?
@@ -3360,6 +3362,8 @@ def sortlevel(self, level=0, axis=0, ascending=True, inplace=False, | |||
DataFrame.sort_index(level=...) | |||
|
|||
""" | |||
warnings.warn("sortlevel is deprecated, use sort_index(...)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe 'sort_index(level=...)' to be a bit more specific?
@@ -2006,6 +2008,8 @@ def sortlevel(self, level=0, ascending=True, sort_remaining=True): | |||
Series.sort_index(level=...) | |||
|
|||
""" | |||
warnings.warn("sortlevel is deprecated, use sort_index(...)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Current coverage is 84.75% (diff: 77.77%)@@ master #15099 diff @@
==========================================
Files 145 145
Lines 51220 51220
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43415 43414 -1
- Misses 7805 7806 +1
Partials 0 0
|
updated |
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202. Follow-up to pandas-devgh-23375.
closes #14279