From 1c1b99e60e638dc21ccf029350f16ff04c3cc29d Mon Sep 17 00:00:00 2001 From: Tom Augspurger Date: Sun, 31 Jan 2016 09:59:14 -0600 Subject: [PATCH] DEPR: deprecate options.display.mpl_style Closes https://github.com/pydata/pandas/issues/11783 --- doc/source/10min.rst | 5 +---- doc/source/computation.rst | 5 +---- doc/source/cookbook.rst | 5 +---- doc/source/faq.rst | 5 +---- doc/source/groupby.rst | 5 +---- doc/source/missing_data.rst | 5 +---- doc/source/options.rst | 6 ------ doc/source/whatsnew/v0.18.0.txt | 9 +++++++++ pandas/core/config_init.py | 9 +++++++++ pandas/tests/test_graphics.py | 12 +++++++++--- 10 files changed, 33 insertions(+), 33 deletions(-) diff --git a/doc/source/10min.rst b/doc/source/10min.rst index 8dbe130bffb68..d51290b2a983b 100644 --- a/doc/source/10min.rst +++ b/doc/source/10min.rst @@ -11,10 +11,7 @@ np.random.seed(123456) np.set_printoptions(precision=4, suppress=True) import matplotlib - try: - matplotlib.style.use('ggplot') - except AttributeError: - pd.options.display.mpl_style = 'default' + matplotlib.style.use('ggplot') pd.options.display.max_rows = 15 #### portions of this were borrowed from the diff --git a/doc/source/computation.rst b/doc/source/computation.rst index ed3251efc3656..2b8cf7e41431b 100644 --- a/doc/source/computation.rst +++ b/doc/source/computation.rst @@ -8,10 +8,7 @@ np.set_printoptions(precision=4, suppress=True) import pandas as pd import matplotlib - try: - matplotlib.style.use('ggplot') - except AttributeError: - pd.options.display.mpl_style = 'default' + matplotlib.style.use('ggplot') import matplotlib.pyplot as plt plt.close('all') pd.options.display.max_rows=15 diff --git a/doc/source/cookbook.rst b/doc/source/cookbook.rst index 1d301c1ee2f19..0dbc79415af0b 100644 --- a/doc/source/cookbook.rst +++ b/doc/source/cookbook.rst @@ -19,10 +19,7 @@ pd.options.display.max_rows=15 import matplotlib - try: - matplotlib.style.use('ggplot') - except AttributeError: - pd.options.display.mpl_style = 'default' + matplotlib.style.use('ggplot') np.set_printoptions(precision=4, suppress=True) diff --git a/doc/source/faq.rst b/doc/source/faq.rst index 39af96fa98df7..e5d659cc31606 100644 --- a/doc/source/faq.rst +++ b/doc/source/faq.rst @@ -14,10 +14,7 @@ Frequently Asked Questions (FAQ) import pandas as pd pd.options.display.max_rows = 15 import matplotlib - try: - matplotlib.style.use('ggplot') - except AttributeError: - pd.options.display.mpl_style = 'default' + matplotlib.style.use('ggplot') import matplotlib.pyplot as plt plt.close('all') diff --git a/doc/source/groupby.rst b/doc/source/groupby.rst index 61f87ebe0db1b..1d1dd59efff52 100644 --- a/doc/source/groupby.rst +++ b/doc/source/groupby.rst @@ -10,10 +10,7 @@ import pandas as pd pd.options.display.max_rows = 15 import matplotlib - try: - matplotlib.style.use('ggplot') - except AttributeError: - pd.options.display.mpl_style = 'default' + matplotlib.style.use('ggplot') import matplotlib.pyplot as plt plt.close('all') diff --git a/doc/source/missing_data.rst b/doc/source/missing_data.rst index 96ae46621dca2..fcc8ac896b9f0 100644 --- a/doc/source/missing_data.rst +++ b/doc/source/missing_data.rst @@ -7,10 +7,7 @@ import pandas as pd pd.options.display.max_rows=15 import matplotlib - try: - matplotlib.style.use('ggplot') - except AttributeError: - pd.options.display.mpl_style = 'default' + matplotlib.style.use('ggplot') import matplotlib.pyplot as plt .. _missing_data: diff --git a/doc/source/options.rst b/doc/source/options.rst index d00ba047a56a6..be1543f20a461 100644 --- a/doc/source/options.rst +++ b/doc/source/options.rst @@ -361,12 +361,6 @@ display.max_seq_items 100 when pretty-printing a long sequence, display.memory_usage True This specifies if the memory usage of a DataFrame should be displayed when the df.info() method is invoked. -display.mpl_style None Setting this to 'default' will modify - the rcParams used by matplotlib - to give plots a more pleasing visual - style by default. Setting this to - None/False restores the values to - their initial value. display.multi_sparse True "Sparsify" MultiIndex display (don't display repeated elements in outer levels within groups) diff --git a/doc/source/whatsnew/v0.18.0.txt b/doc/source/whatsnew/v0.18.0.txt index d52e0e3098b98..f54774ebe8dd6 100644 --- a/doc/source/whatsnew/v0.18.0.txt +++ b/doc/source/whatsnew/v0.18.0.txt @@ -816,6 +816,15 @@ Deprecations - ``pandas.stats.ols``, ``pandas.stats.plm`` and ``pandas.stats.var`` routines are deprecated and will be removed in a future version (:issue:`6077`) - show a ``FutureWarning`` rather than a ``DeprecationWarning`` on using long-time deprecated syntax in ``HDFStore.select``, where the ``where`` clause is not a string-like (:issue:`12027`) +- The ``pandas.options.display.mpl_style`` configuration has been deprecated + and will be removed in a future version of pandas. This functionality + is better handled by matplotlib's `style sheets`_ (:issue:`11783`). + + + + +.. _style sheets: http://matplotlib.org/users/style_sheets.html + .. _whatsnew_0180.prior_deprecations: Removal of prior version deprecations/changes diff --git a/pandas/core/config_init.py b/pandas/core/config_init.py index 93a6968be8602..cf8a06465a7a4 100644 --- a/pandas/core/config_init.py +++ b/pandas/core/config_init.py @@ -9,6 +9,7 @@ module is imported, register them here rather then in the module. """ +import warnings import pandas.core.config as cf from pandas.core.config import (is_int, is_bool, is_text, is_instance_factory, @@ -222,6 +223,11 @@ Setting this to None/False restores the values to their initial value. """ +pc_mpl_style_deprecation_warning = """ +mpl_style had been deprecated and will be removed in a future version. +Use `matplotlib.pyplot.style.use` instead. +""" + pc_memory_usage_doc = """ : bool, string or None This specifies if the memory usage of a DataFrame should be displayed when @@ -246,6 +252,9 @@ def mpl_style_cb(key): + warnings.warn(pc_mpl_style_deprecation_warning, FutureWarning, + stacklevel=4) + import sys from pandas.tools.plotting import mpl_stylesheet global style_backup diff --git a/pandas/tests/test_graphics.py b/pandas/tests/test_graphics.py index add7245561d3f..f224016be1e49 100644 --- a/pandas/tests/test_graphics.py +++ b/pandas/tests/test_graphics.py @@ -3774,9 +3774,15 @@ def test_df_grid_settings(self): plotting._dataframe_kinds, kws={'x': 'a', 'y': 'b'}) def test_option_mpl_style(self): - set_option('display.mpl_style', 'default') - set_option('display.mpl_style', None) - set_option('display.mpl_style', False) + with tm.assert_produces_warning(FutureWarning, + check_stacklevel=False): + set_option('display.mpl_style', 'default') + with tm.assert_produces_warning(FutureWarning, + check_stacklevel=False): + set_option('display.mpl_style', None) + with tm.assert_produces_warning(FutureWarning, + check_stacklevel=False): + set_option('display.mpl_style', False) with tm.assertRaises(ValueError): set_option('display.mpl_style', 'default2')