Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: cythonize groupby.count #7003

Closed
jreback opened this issue Apr 29, 2014 · 2 comments · Fixed by #7016
Closed

PERF: cythonize groupby.count #7003

jreback opened this issue Apr 29, 2014 · 2 comments · Fixed by #7016
Labels
Groupby Performance Memory or execution speed performance
Milestone
0.14.1

Comments

@jreback
Copy link
Contributor

jreback commented Apr 29, 2014

see #7000
@jreback jreback added this to the 0.14.1 milestone Apr 29, 2014
@jreback jreback mentioned this issue Apr 29, 2014
Merged
@rockg
Copy link
Contributor

rockg commented Apr 30, 2014

This is just adding group_count_* templates to src/generated_code.py? I think I have this already somewhere.

@jreback
Copy link
Contributor Author

jreback commented Apr 30, 2014

yes, though the template has to be generated slightly differently (as it accepts all dtypes), regular functions have a more limited dtype set (e.g. float/int/obj)

I think needs some transformation when called

and of course tests...so 'easy' but some details

@cpcloud cpcloud mentioned this issue Apr 30, 2014
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Groupby Performance Memory or execution speed performance
Projects
None yet
Milestone
0.14.1
Development

Successfully merging a pull request may close this issue.

ENH: cythonize groupby.count
2 participants
@jreback @rockg