BUG: Fix multi-index on columns with bool level values does not roundtrip through parquet #60519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trip through parquet
rhshadrach
reviewed
Dec 8, 2024
Comment on lines
+128
to
+134
| if arr.dtype == object and dtype == bool: | ||
| # If the dtype is bool and the array is object, we need to replace | ||
| # the False and True of the object type in the ndarray with the | ||
| # bool type to ensure that the type conversion is correct | ||
| arr[arr == "False"] = np.False_ | ||
| arr[arr == "True"] = np.True_ | ||
| return arr.astype(dtype, copy=copy) |
There was a problem hiding this comment.
I don't think we should be changing the behavior of astype(bool) to special case certain values.
There was a problem hiding this comment.
I got it. I think the method you mentioned in 60508 is quite reasonable. Thank you for your review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.