Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Change assert_index_equal(exact=) default from "equiv" to True #57436

Open
mroeschke opened this issue Feb 15, 2024 · 1 comment
Open

API: Change assert_index_equal(exact=) default from "equiv" to True #57436

mroeschke opened this issue Feb 15, 2024 · 1 comment
Labels
API Design Index Related to the Index class or subclasses Testing pandas testing functions or related to the test suite

Comments

@mroeschke
Copy link
Member

Recently, #57429 slipped through the cracks because Index[int64] is considered equal to RangeIndex. While convenient, this allows code changes to potentially introduce a change that leads to increase in memory usage (or decrease in the hopeful case). I don't think this lack of clarity is worth the convenience of making Index[int64] equivalent to RangeIndex by default and therefore exact should default to True
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite API Design Index Related to the Index class or subclasses labels Feb 15, 2024
@mroeschke mroeschke mentioned this issue Feb 15, 2024
Merged
@rhshadrach
Copy link
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Index Related to the Index class or subclasses Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroeschke @rhshadrach