-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Downcasting neither warned against nor discussed in documentation #50214
Comments
This is not discussed in the documentation, yet the issue is closed. |
PRs are welcome I guess. Not sure where to add this though. It should be more or less clear that we return python dtypes based on the examples in the docs |
In the dtypes section (linked above), they use |
Related to #50213. |
This is perfectly fine, but they get converted to python floats instead of np.float32() objects when writing them out, like printing or csv. |
Okay, I'll take it. This is still unanswered though:
|
Please comment only in one issue |
I just realized I didn't name this issue. These issues are separate, but use the same example. |
Not sure what you mean with downcasting, but you can cast whatever you want, we don’t warn about loss of data right now |
Opposite of upcasting. There would only need to be a warning if risking data loss, which you say is not implemented. This is fine to not implement, so long as it is mentioned in the docs. I feel a downcasting section could be added to the link in this comment. |
Pandas version checks
I have checked that this issue has not already been reported.
I have confirmed this bug exists on the latest version of pandas.
I have confirmed this bug exists on the main branch of pandas.
Reproducible Example
Issue Description
Downcasting neither warned against nor discussed in the documentation. Upcasting has a section under dytpes, and downcasting is mentioned only within the scope of
pd.to_numeric()
.Further, I'm not sure if the behavior is undefined because for
float16
the mantissa is 10 bits which means it should max out at 1023, yet 10.25 (1025e-2) and up are preserved.pd.DataFrame.round() does not seem to take effect when using NumPy
datatypes.
Expected Behavior
Installed Versions
INSTALLED VERSIONS
commit : 8dab54d
python : 3.10.8.final.0
python-bits : 64
OS : Linux
OS-release : 6.0.12-arch1-1
Version : #1 SMP PREEMPT_DYNAMIC Thu, 08 Dec 2022 11:03:38 +0000
machine : x86_64
processor :
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8
pandas : 1.5.2
numpy : 1.23.5
pytz : 2021.3
dateutil : 2.8.2
setuptools : 58.1.0
pip : 22.3.1
Cython : 0.29.32
pytest : None
hypothesis : None
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : 4.9.1
html5lib : 1.1
pymysql : None
psycopg2 : None
jinja2 : 3.1.2
IPython : 8.4.0
pandas_datareader: None
bs4 : 4.11.1
bottleneck : None
brotli : None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : 3.5.2
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : None
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : 1.8.1
snappy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
xlwt : None
zstandard : None
tzdata : None
None
The text was updated successfully, but these errors were encountered: