Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: subclassing Index #45289

Closed
jbrockmendel opened this issue Jan 9, 2022 · 2 comments · Fixed by #52186
Closed

DEPR: subclassing Index #45289

jbrockmendel opened this issue Jan 9, 2022 · 2 comments · Fixed by #52186
Labels
Deprecate Functionality to remove in pandas Docs Index Related to the Index class or subclasses

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Jan 9, 2022 •
edited
Loading

In theory we support subclassing Index, but that support is spotty (xref #15258, #37882). Now that we allow arbitrary EAs in Index, we should deprecate that and direct downstream libraries to use EAs instead.

xref pydata/xarray#6129
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member Deprecate Functionality to remove in pandas and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 9, 2022
@mroeschke mroeschke added the Index Related to the Index class or subclasses label Jan 13, 2022
@pandas-dev pandas-dev deleted a comment from jbrockmendel Jan 14, 2022
@rhshadrach
Copy link
Member

For this deprecation, is this merely a docs change or would we be actively stopping users from subclassing Index?

@jbrockmendel
Copy link
Member Author

I think just a docs change

@jbrockmendel jbrockmendel mentioned this issue Jul 6, 2022
Open
@jbrockmendel jbrockmendel mentioned this issue Mar 24, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Docs Index Related to the Index class or subclasses
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: subclassing Index jbrockmendel/pandas
3 participants
@jbrockmendel @mroeschke @rhshadrach