Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC/CI: fix doc build with Python 3.9 #41096

Closed
jorisvandenbossche opened this issue Apr 22, 2021 · 8 comments
Closed

DOC/CI: fix doc build with Python 3.9 #41096

jorisvandenbossche opened this issue Apr 22, 2021 · 8 comments
Labels
CI Continuous Integration Docs

Comments

@jorisvandenbossche
Copy link
Member

The doc build was failing on master (/home/runner/work/pandas/pandas/doc/source/reference/api/pandas.Series.dt.rst: WARNING: document isn't included in any toctree), which started when the environment switched to Python 3.9.

It is now pinned to Python 3.8 (#41092), but we should fix the warning for Python 3.9, and unpin the environment.

cc @pandas-dev/pandas-docs
@jorisvandenbossche jorisvandenbossche added Docs CI Continuous Integration labels Apr 22, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Apr 22, 2021
@jorisvandenbossche jorisvandenbossche mentioned this issue Apr 22, 2021
Merged
@simonjayhawkins simonjayhawkins modified the milestones: 1.3, 1.2.5 Apr 22, 2021
@simonjayhawkins
Copy link
Member

@jorisvandenbossche changed the milestone since we want to do this before the 1.2.5 release.

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Apr 22, 2021 •
edited
Loading

To be clear, the docs are still building fine now. I think it's OK if we need to keep the Python 3.8 pin on the 1.2.x branch?

@simonjayhawkins
Copy link
Member

The thing is, since we are changing environment.yml just for ci, do we want that change in an actual release?

@jorisvandenbossche
Copy link
Member Author

How does the environment.yml impact the release? (eg the file is not included in the sdist)

@simonjayhawkins
Copy link
Member

eg the file is not included in the sdist

didn't know that.

1 similar comment
@simonjayhawkins
Copy link
Member

eg the file is not included in the sdist

didn't know that.

@simonjayhawkins simonjayhawkins modified the milestones: 1.2.5, 1.3 Apr 22, 2021
@simonjayhawkins
Copy link
Member

eg the file is not included in the sdist

didn't know that.

removing the milestone

@simonjayhawkins simonjayhawkins removed this from the 1.3 milestone Jun 8, 2021
@phofl
Copy link
Member

phofl commented Apr 17, 2023

Lets track in #52513

@phofl phofl closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jorisvandenbossche @mroeschke @simonjayhawkins @phofl