-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: fix template substitution in pad/bfill docstrings #39978
DOC: fix template substitution in pad/bfill docstrings #39978
Conversation
cc @simonjayhawkins @jorisvandenbossche lgtm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also fix bfill/backfill while doing this. basically same issue, needs same change applied to L6516
yeah I can do that. I'm not sure what "Igtm" or "L6516" mean/referring to, if I need to know then could someone let me know please. |
@dylanp-git lgtm means 'looks good to me'; L6516 is line number 6516 |
aha thankyou, I'm slowly learning the lingo!! |
Thanks a lot @dylanp-git ! |
…fill docstrings
No worries! I was going to look into it again later as only 20/22 checks passed? On another note, how many "good first issue" issues do you think I should do before trying something a bit more in-depth? |
the failures were unrelated (sometimes that happens)
IMO if you've got familiar with the contribution workflow then you could start immediately |
…rings (#40017) Co-authored-by: Dylan Percy <[email protected]>
#39640 Added doc tag above ffill() to substitute klass