Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: Make function for dtype casting in pre-processing of groupby #37505

Open
phofl opened this issue Oct 29, 2020 · 1 comment
Open

REF: Make function for dtype casting in pre-processing of groupby #37505

phofl opened this issue Oct 29, 2020 · 1 comment
Labels
Clean Groupby Refactor Internal refactoring of code Resample resample method

Comments

@phofl
Copy link
Member

phofl commented Oct 29, 2020

Is your feature request related to a problem?

[this should provide a description of what the problem is, e.g. "I wish I could use pandas to do [...]"]

Describe the solution you'd like

As mentioned in #37145 the pre processing part in

pandas/pandas/core/groupby/groupby.py

Line 2174 in 6abe510

elif is_datetime64_dtype(vals.dtype):
is very generic and could be moved to a function
@phofl phofl added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member Groupby Resample resample method labels Oct 29, 2020
This was referenced Oct 29, 2020
Merged
Closed
@rhshadrach rhshadrach added Clean and removed Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 6, 2021
@rhshadrach rhshadrach added this to the Contributions Welcome milestone Feb 6, 2021
@mroeschke mroeschke added the Refactor Internal refactoring of code label Aug 14, 2021
@mroeschke mroeschke changed the title ENH: Make function for dtype casting in pre-processing of groupby REF: Make function for dtype casting in pre-processing of groupby Aug 14, 2021
@jbrockmendel jbrockmendel mentioned this issue Feb 22, 2022
Open
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@jbrockmendel
Copy link
Member

@phofl i think #51003 would close this, can you confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Groupby Refactor Internal refactoring of code Resample resample method
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbrockmendel @mroeschke @rhshadrach @phofl