Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: bump numpy min version? #33718

Closed
jbrockmendel opened this issue Apr 21, 2020 · 5 comments · Fixed by #33729
Closed

DEP: bump numpy min version? #33718

jbrockmendel opened this issue Apr 21, 2020 · 5 comments · Fixed by #33729
Labels
Dependencies Required and optional dependencies
Milestone

Comments

@jbrockmendel
Copy link
Member

We currently require 1.13.3 which was released 2017-09-29. The last bump was in 0.25.0 (#25554).

I think its time for another bump. The release dates for the 1.x.0 and 1.x.MAX versions out there:

1.14.0 -> 2018-01-06
1.14.6 -> 2018-09-23
1.15.0 -> 2018-07-23
1.15.4 -> 2018-11-04
1.16.0 -> 2019-01-13
1.16.6 -> 2019-12-29
1.17.0 -> 2019-07-06
1.17.5 -> 2020-01-01

1.15.4 looks not-unreasonable to me.

@jbrockmendel jbrockmendel added Usage Question Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 21, 2020
@mroeschke mroeschke added Dependencies Required and optional dependencies and removed Needs Triage Issue that has not been reviewed by a pandas team member Usage Question labels Apr 22, 2020
@jreback
Copy link
Contributor

jreback commented Apr 22, 2020

+1 in bumping to 1.15.x

even 1.16.x is ok

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Apr 22, 2020

According to https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule, NumPy 1.14 can / should be dropped after

On Jan 07, 2020 drop support for Numpy 1.14 (initially released on Jan 06, 2018)

@jorisvandenbossche
Copy link
Member

I would also follow NEP29, which means np 1.14 for pandas 1.1 (and then can probably go to np 1.15 after pandas 1.1 is released)

@TomAugspurger
Copy link
Contributor

@jorisvandenbossche doesn't NEP29 say we're already supposed to drop 1.14, since it's the next release after January 7, 2020?

@jorisvandenbossche
Copy link
Member

Whoops, sorry, yes I should have said 1.15 and 1.16, instead of 1.14 and 1.15

@jreback jreback added this to the 1.1 milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants