Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Numpydev failing #29432

Closed
TomAugspurger opened this issue Nov 6, 2019 · 1 comment · Fixed by #29553
Closed

CI: Numpydev failing #29432

TomAugspurger opened this issue Nov 6, 2019 · 1 comment · Fixed by #29553
Labels
Blocker Blocking issue or pull request for an upcoming release CI Continuous Integration Dependencies Required and optional dependencies
Milestone

Comments

@TomAugspurger
Copy link
Contributor

I can reproduce with numpy master

==================================== ERRORS ====================================
__________ ERROR collecting pandas/tests/arrays/sparse/test_array.py ___________
pandas/tests/arrays/sparse/test_array.py:22: in <module>
    class TestSparseArray:
pandas/tests/arrays/sparse/test_array.py:511: in TestSparseArray
    dtype=SparseDtype("datetime64[ns]", pd.Timestamp("1970")),
pandas/core/arrays/sparse/array.py:364: in __init__
    data, kind=kind, fill_value=fill_value, dtype=dtype
pandas/core/arrays/sparse/array.py:1584: in make_sparse
    sparsified_values = arr[mask]
E   IndexError: arrays used as indices must be of integer (or boolean) type
--------- generated xml file: /home/vsts/work/1/s/test-data-single.xml ---------
========================== slowest 10 test durations ===========================
(Pdb) pp arr
array(['1970-01-01T00:00:00.000000000', '1970-01-01T00:00:00.000000001'],
      dtype='datetime64[ns]')
(Pdb) pp fill_value
Timestamp('1970-01-01 00:00:00')
(Pdb) pp arr != fill_value
array([True, True], dtype=object)

Previously, that was bool dtype

In [6]: np.array(['1970-01-01T00:00:00.000000000', '1970-01-01T00:00:00.000000001'],
   ...:       dtype='datetime64[ns]') == pd.Timestamp('1970-01-01 00:00:00')
Out[6]: array([False, False])
@TomAugspurger
Copy link
Contributor Author

See numpy/numpy#14800 (comment) for whats going on. Not sure if it's a regression or deliberate. Will work around it for now in #29433

@gfyoung gfyoung added CI Continuous Integration Dependencies Required and optional dependencies labels Nov 6, 2019
@jreback jreback added this to the 1.0 milestone Nov 6, 2019
@TomAugspurger TomAugspurger added the Blocker Blocking issue or pull request for an upcoming release label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Blocking issue or pull request for an upcoming release CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants