-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT: the json C code should not deal with blocks #27164
Comments
Took a look and I think getting rid of this really simplifies the code. Have one failure I haven't seen yet and need to check for memory leaks but will post a PR for you to review |
+1 on this idea. IIRC there was a discussion a few months ago about trying to get internals out of the ujson code and the conclusion was "wait and see if we can use the arrow parser instead". Since the latter is a non-starter for the moment, making this code more maintainable would be great. |
just noticed that get_block_values is just an alias for get_values. Any reason not to just use get_values (until block usage can be removed entirely)? |
PR #26409 introduced a
get_block_values
to get the values of the Block, used in https://github.com/pandas-dev/pandas/blob/master/pandas/_libs/src/ujson/python/objToJSON.cIdeally, the JSON C code should not deal with blocks (eg by converting to a numpy array before passing the data to the C code).
So to do item for this issue: update the JSON code so the call from objToJSON.c to
get_block_values
can be removed.The text was updated successfully, but these errors were encountered: