Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Type Annotation in pandas/core/accessor.py #26146

Closed
vaibhavhrt opened this issue Apr 19, 2019 · 2 comments · Fixed by #26147
Closed

Fix Type Annotation in pandas/core/accessor.py #26146

vaibhavhrt opened this issue Apr 19, 2019 · 2 comments · Fixed by #26147
Labels
Typing type annotations, mypy/pyright type checking
Milestone
0.25.0

Comments

@vaibhavhrt
Copy link
Contributor

Part of #25882

Current errors are:

pandas\core\accessor.py:14: error: Need type annotation for '_accessors'

PR coming soon
@vaibhavhrt vaibhavhrt mentioned this issue Apr 19, 2019
Merged
4 tasks
@vaibhavhrt
Copy link
Contributor Author

@WillAyd pandas.core.apply is in mypy.ini but mypy shows no errors in that file. Should I just remove it from mypy.ini in same PR for this issue or should I open a new issue and PR

@WillAyd
Copy link
Member

WillAyd commented Apr 19, 2019 via email

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Apr 19, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 20, 2019
@gwrome gwrome mentioned this issue May 2, 2019
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Fix Type Annotation in pandas.core.accessor vaibhavhrt/pandas
3 participants
@WillAyd @jreback @vaibhavhrt