Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Type Annotations in pandas/compat/numpy/function.py #25950

Closed
vaibhavhrt opened this issue Apr 1, 2019 · 2 comments · Fixed by #25961
Closed

Fix Type Annotations in pandas/compat/numpy/function.py #25950

vaibhavhrt opened this issue Apr 1, 2019 · 2 comments · Fixed by #25961
Labels
Typing type annotations, mypy/pyright type checking
Milestone
0.25.0

Comments

@vaibhavhrt
Copy link
Contributor

Part of #25882

Current errors are as follows:

mypy pandas/compat/numpy/function.py

pandas\compat\numpy\function.py:104: error: Need type annotation for 'ARGSORT_DEFAULTS'
pandas\compat\numpy\function.py:105: error: Cannot determine type of 'ARGSORT_DEFAULTS'
pandas\compat\numpy\function.py:106: error: Cannot determine type of 'ARGSORT_DEFAULTS'
pandas\compat\numpy\function.py:107: error: Cannot determine type of 'ARGSORT_DEFAULTS'
pandas\compat\numpy\function.py:108: error: Cannot determine type of 'ARGSORT_DEFAULTS'
pandas\compat\numpy\function.py:113: error: Need type annotation for 'ARGSORT_DEFAULTS_KIND'
pandas\compat\numpy\function.py:114: error: Cannot determine type of 'ARGSORT_DEFAULTS_KIND'
pandas\compat\numpy\function.py:115: error: Cannot determine type of 'ARGSORT_DEFAULTS_KIND'
pandas\compat\numpy\function.py:116: error: Cannot determine type of 'ARGSORT_DEFAULTS_KIND'
pandas\compat\numpy\function.py:158: error: Need type annotation for 'COMPRESS_DEFAULTS'
pandas\compat\numpy\function.py:159: error: Cannot determine type of 'COMPRESS_DEFAULTS'
pandas\compat\numpy\function.py:160: error: Cannot determine type of 'COMPRESS_DEFAULTS'
pandas\compat\numpy\function.py:161: error: Cannot determine type of 'COMPRESS_DEFAULTS'
pandas\compat\numpy\function.py:164: error: Need type annotation for 'CUM_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:165: error: Cannot determine type of 'CUM_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:166: error: Cannot determine type of 'CUM_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:167: error: Cannot determine type of 'CUM_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:169: error: Cannot determine type of 'CUM_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:188: error: Need type annotation for 'ALLANY_DEFAULTS'
pandas\compat\numpy\function.py:189: error: Cannot determine type of 'ALLANY_DEFAULTS'
pandas\compat\numpy\function.py:190: error: Cannot determine type of 'ALLANY_DEFAULTS'
pandas\compat\numpy\function.py:191: error: Cannot determine type of 'ALLANY_DEFAULTS'
pandas\compat\numpy\function.py:192: error: Cannot determine type of 'ALLANY_DEFAULTS'
pandas\compat\numpy\function.py:194: error: Cannot determine type of 'ALLANY_DEFAULTS'
pandas\compat\numpy\function.py:218: error: Need type annotation for 'SORT_DEFAULTS'
pandas\compat\numpy\function.py:219: error: Cannot determine type of 'SORT_DEFAULTS'
pandas\compat\numpy\function.py:220: error: Cannot determine type of 'SORT_DEFAULTS'
pandas\compat\numpy\function.py:221: error: Cannot determine type of 'SORT_DEFAULTS'
pandas\compat\numpy\function.py:222: error: Cannot determine type of 'SORT_DEFAULTS'
pandas\compat\numpy\function.py:225: error: Need type annotation for 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:226: error: Cannot determine type of 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:227: error: Cannot determine type of 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:229: error: Cannot determine type of 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:233: error: Cannot determine type of 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:237: error: Cannot determine type of 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:239: error: Cannot determine type of 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:245: error: Cannot determine type of 'STAT_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:250: error: Need type annotation for 'STAT_DDOF_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:251: error: Cannot determine type of 'STAT_DDOF_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:252: error: Cannot determine type of 'STAT_DDOF_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:253: error: Cannot determine type of 'STAT_DDOF_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:254: error: Cannot determine type of 'STAT_DDOF_FUNC_DEFAULTS'
pandas\compat\numpy\function.py:257: error: Need type annotation for 'TAKE_DEFAULTS'
pandas\compat\numpy\function.py:258: error: Cannot determine type of 'TAKE_DEFAULTS'
pandas\compat\numpy\function.py:259: error: Cannot determine type of 'TAKE_DEFAULTS'
pandas\compat\numpy\function.py:260: error: Cannot determine type of 'TAKE_DEFAULTS'
@vaibhavhrt
Copy link
Contributor Author

PR Coming Soon.

@vaibhavhrt vaibhavhrt mentioned this issue Apr 2, 2019
Merged
4 tasks
@vaibhavhrt
Copy link
Contributor Author

@WillAyd you might wanna add label to this issue too.

@jschendel jschendel added the Typing type annotations, mypy/pyright type checking label Apr 3, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Fix type annotation in pandas.compat.numpy.function vaibhavhrt/pandas
3 participants
@jreback @jschendel @vaibhavhrt