-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Split api.rst in sections #24451
Comments
I agree, think this would definitely more approachable split up into pages; it's far too monolithic as it stands. Makes sense to follow the sections already defined. |
Makes sense to me. One small nit is that I would combine |
@datapythonista I agree with your rationale ... but, this completely breaks all existing links to the api docs. There might be some easy fixes (adding a (temporary) redirect, or keeping the generated pages in This will be in general a problem when reorganizing the docs, so it would be good to find some remedies for this. |
So there are two issues:
This depends a bit on how the page is used. I personally use it for finding (the docstring page of) a certain function/method typically with ctrl-f. Having it split over many pages makes this actually harder .. (although I am probably an atypical user of the page). |
the path of the generated files is decided by sphinx based on where the Regarding the redirects it was briefly discussed in #23708 (comment) And as said there, in my opinion, redirecting everything (also consider what I'm proposing in #24499) is not worth the effort and complexity. It'd be surely nice to have a better 404 that let the users continue the navigation and find the new page, but I wouldn't build a system to add redirects to possibly every single page of the docs. I see the convinience of a ctrl+f in a single page, but I'd leave that for the pdf version of the docs, and move to the opposite direction in the html, and not have to ctrl+f anything because everything is easy to navigate. |
Why wouldn't we want that?
I certainly agree that at some point when properly reorganising the full doc structure, it is going to be impossible (and not worth the effort) to keep urls working. |
I'm waiting to see if anyone else wants to give feedback in #24499 before working on it. But I don't see the reorganisation of the full docs happening at "some point", but in the near future. :) I think not much later after that is merged, it would be a good time to change the sphinx style, and we could switch to pandas.io (and dev.pandas.io) at the same time. While I totally understand your point, my opinion is that it's better to forget about redirects (including deleting the redirects we already have). Search engines will take some time until they have everything indexed again. But I'd just make sure that any url under pandas.pydata.org explains that we moved and link the new page, and IMO that should be enough for the time search engines take to be updated. An advantage I see besides the simplicity, is that if we redirect users to the new home pages, they'll see the value in the new navigation and get used to it (instead of using search engines). |
It's not only about search engines, but also all the links to docstring pages in blogs, StackOverflow answers, ... When we would move to pandas.io, I assume we will also have redirects from pandas.pydata.org/pandas-docs/ over there no?
Certainly true for all the user guide docs. But even with a fantastic navigation, I will probably still keep using google to go to a specific docstring page :) Anyway, I still feel it is not needed to break all the API pages (if we would change the url, I think I would actually rather go with |
I see your point, there is obviously a tradeoff on not breaking the urls around, and keeping things simple. I'm biased towards keeping things simple. But if there is agreement that the impact of breaking the old links would be bad enough that it's worth adding the complexity of the redirects to the docs, that's ok with me. |
About the |
Personally I think it is worth it (but happy to hear other people's thoughts as well), and I think the redirect (for simple old->new cases) is not that complex.
Is that for a developer perspective? (open that folder in a file browser can indeed be a bit annoying) BTW, what do you think of using 'reference' instead of 'api' ? (although that also makes the url longer .. :-)) |
Assuming we all agree that the generated files should be separate from the API section pages, we need to names, one for the top directory (now sklearn uses You've seen the issue for the redirects, there is a PR open already. I think that should be good enough. |
This can be closed right, as the redirects are now in place? |
Not yet, we need to add the list of pages to redirect to |
If we choose a new name, I think I would go for '/reference/api'. Or '/api/reference', or leave the '/api/generated/. |
@datapythonista do you have time to do the redirects now? Otherwise I can also look at it, as this one is blocking the release. |
Will have a look now, but I won't move anything if you want to have it now, just create the redirects. I mentioned in another issue, can you take a look at #24890. I think it should go into 0.24, that's the last piece of the restructuring, the way it is now doesn't make much sense (having all the comparison_with... in the top level, and other things). |
@jorisvandenbossche opened #24909. Any thoughts on merging #24890 before the release? |
The pandas API reference page is huge. Which makes it difficult for users to find information, and for us to edit.
Given the size of the page, I think it'd make more sense to split the current page
api.rst
into different pages, one per section:api/series.rst
api/functions.rst
The document is already divided into sections, I think the current division would make sense with few changes:
api.rst
)Does anybody think a single page is better? Any other division you think of?
The text was updated successfully, but these errors were encountered: